Improve collection node testing, reveal double-load issue. #trivial #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
changed the title
Adlai-Holler
force-pushed
the
AHBetterCollectionTest1
branch
4 times, most recently
from
6f700b9 to
b0bd856
Compare
Adlai-Holler
force-pushed
the
AHBetterCollectionTest1
branch
from
b0bd856 to
59fcb40
Compare
maicki
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was building some new API for collection node, and I decided to create a new, leaner, better test harness and it revealed a major issue (#351) so I'm opening this diff now to get it in the bank.
ASTestCase. Subclass this for new test cases. In itstearDownmethod, it clears all the test case ivars and clears all UIWindows. This majorly helps reduce pollution between test methods.OCMockObjectthat lets you specify which optional protocol methods should exist. This is extremely useful because the default behavior is to assume they all exist, which violates framework invariants and makes most testing of complex data sources impossible.ASCollectionModernDataSourceTests.m.