Only call -layout and -layoutDidFinish if the node is already loaded#285
Merged
nguyenhuy merged 4 commits intoTextureGroup:masterfrom May 19, 2017
Merged
Conversation
nguyenhuy
force-pushed
the
HNLayoutBeforeLoading
branch
from
11d6526 to
5315e3f
Compare
maicki
approved these changes
May 17, 2017
Contributor
maicki
left a comment
maicki
left a comment
There was a problem hiding this comment.
Change looks good to me!
We should finally push on finding a better way to have layout code path go through one path ...
Member
Author
|
@maicki Agreed... |
|
🚫 CI failed with log |
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
…extureGroup#285) * Only call -layout and -layoutDidFinish if the node is already loaded * Minor change * Update CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After facebookarchive/AsyncDisplayKit#3263, a layout pass can be triggered even before a node is loaded. This is to ensure the node has valid bounds to fetch its content as soon as it enters preload state, regardless of its backing store.
However, the API contracts of
-layoutand-layoutDidFinishstate that those methods are triggered by the view'slayoutSubviews. That means the node must be loaded by the time they are called.This PR adds a node loaded check to
__layoutthat ensures those 2 methods are called only if the condition meets.