Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASImageNode] Add documentation for image effects #trivial #263

Merged
merged 2 commits into from
Jun 20, 2017

Conversation

maicki
Copy link
Contributor

@maicki maicki commented May 12, 2017

No description provided.

@maicki maicki changed the title [ASImageNode] Add documentation for image effects [ASImageNode] Add documentation for image effects #trivial May 12, 2017
@maicki maicki force-pushed the MSImageNodeEffectsDocumentation branch from 096906a to bd9fe50 Compare May 15, 2017 16:54
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice write up! Since we already have a dedicated page for image modification block here, maybe we should have a new image effects section with a short explanation and then link to that page?

@maicki
Copy link
Contributor Author

maicki commented May 18, 2017

@nguyenhuy Agree. I will take another step on that soon when time allows.

@maicki maicki changed the title [ASImageNode] Add documentation for image effects #trivial [WIP] [ASImageNode] Add documentation for image effects #trivial May 19, 2017
@maicki maicki force-pushed the MSImageNodeEffectsDocumentation branch from bd9fe50 to a46b8d4 Compare June 20, 2017 14:47
@ghost
Copy link

ghost commented Jun 20, 2017

1 Warning
⚠️ PR is classed as Work in Progress

Generated by 🚫 Danger

@maicki maicki changed the title [WIP] [ASImageNode] Add documentation for image effects #trivial [ASImageNode] Add documentation for image effects #trivial Jun 20, 2017
@maicki
Copy link
Contributor Author

maicki commented Jun 20, 2017

@nguyenhuy Added changes based on your feedback.

Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nguyenhuy nguyenhuy merged commit 0a7f8ea into master Jun 20, 2017
@nguyenhuy
Copy link
Member

@maicki Hm, the new code snippets aren't rendered correctly: http://texturegroup.org/docs/image-modification-block.html. Could you please take a look?

@maicki
Copy link
Contributor Author

maicki commented Jun 20, 2017

@nguyenhuy Yep will take a look

bernieperez pushed a commit to AtomTickets/Texture that referenced this pull request Apr 25, 2018
…oup#263)

* Add documentation for doing image effects

* Link to image modification documentation in the image node documentation
@maicki maicki deleted the MSImageNodeEffectsDocumentation branch September 8, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants