Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting AVPlayer #1700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow setting AVPlayer #1700

wants to merge 1 commit into from

Conversation

SpartanRASUL
Copy link

Hello. In my previous work, I've run into a problem, where I needed to change standard AVPlayer to AVQueuePlayer, because of it's prefetching feature. So to fix that I usually change the header file with this exact change. I think it may come in handy to other developers, who may want to use AVQueuePlayer instead of AVPlayer.

Hello. In my previous work, I've run into a problem, where I needed to change standard AVPlayer to AVQueuePlayer, because of it's prefetching feature. So to fix that I usually change the header file with this exact change. I think it may come in handy to other developers, who may want to use AVQueuePlayer instead of AVPlayer.
@CLAassistant
Copy link

CLAassistant commented Oct 6, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could instead remove the readonly attribute from the player property:

@property (nullable, readonly) AVPlayer *player;

Copy link
Member

@jparise jparise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could instead remove the readonly attribute from the player property:

@property (nullable, readonly) AVPlayer *player;

@SpartanRASUL
Copy link
Author

@jparise Yeah, really

@SpartanRASUL
Copy link
Author

i'll update this pull request soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants