Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CFRelease on null variable when using truncationAttributedText #1669

Merged

Conversation

MikeDonahue
Copy link
Contributor

I was hitting a crash in ASTextNode2 (in an ASCellNode) while using truncationAttributedText and additionalTruncationMessage. It seemed to only happen on a tap event when maximumNumberOfLines was 0, and the text was long enough to run off screen requiring the user to scroll. The node rendered fine, but crashed as the user touched down to scroll. A quick null check before calling CFRelease was enough to fix it.

@rahul-malik
Copy link
Contributor

@MikeDonahue - Thanks for the fix!

@rahul-malik rahul-malik merged commit 3bb64bc into TextureGroup:master Sep 12, 2019
@MikeDonahue MikeDonahue deleted the fix-truncation-null-release branch September 12, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants