Fix CFRelease on null variable when using truncationAttributedText #1669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hitting a crash in ASTextNode2 (in an ASCellNode) while using
truncationAttributedText
andadditionalTruncationMessage
. It seemed to only happen on a tap event whenmaximumNumberOfLines
was 0, and the text was long enough to run off screen requiring the user to scroll. The node rendered fine, but crashed as the user touched down to scroll. A quick null check before callingCFRelease
was enough to fix it.