Restore call pattern where UIView methods drive __enterHierarchy and __exitHierarchy for view-backed nodes #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…__exitHierarchy for view-backed nodes After TextureGroup#1396, some view-backed nodes in our app stop responding to tap events. I tracked it down to [this change](https://github.com/TextureGroup/Texture/pull/1396/files#diff-7fbc7d84a259cbfbee7546a5310dddcfR162) which suggests that the order of execution matters. This diff attempts to fix the issue by restoring the previous call order where `__enterHierarchy` and `__exitHierarchy` are driven by `_ASDisplayView`'s `-willMoveToWindow:` and `-didMoveToWindow` if the node is view-backed. Layer-backed nodes will still call `__enterHierarchy`/`__exitHierarchy` when they get `kCAOnOrderIn`/`kCAOnOrderOut`. This maintains the layer-action support introduced in TextureGroup#1396.
Adlai-Holler
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1396, some view-backed nodes in our app stop responding to tap events. I tracked this issue down to this change which suggests that the order of execution matters.
This diff attempts to fix the issue by restoring the previous call order where
__enterHierarchyand__exitHierarchyare driven by_ASDisplayView's-willMoveToWindow:and-didMoveToWindowif the node is view-backed. Layer-backed nodes will still call__enterHierarchy/__exitHierarchywhen they getkCAOnOrderIn/kCAOnOrderOut.This maintains the layer-action support introduced in #1396.