Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink _ASCollectionPendingState from 144 to 128 bytes, a 12.5% reduction #1485

Merged
merged 3 commits into from
May 7, 2019
Merged

Shrink _ASCollectionPendingState from 144 to 128 bytes, a 12.5% reduction #1485

merged 3 commits into from
May 7, 2019

Commits on May 3, 2019

  1. Shrink _ASCollectionPendingState from 144 to 128 bytes, a 12.5% reduc… 

    …tion

These objects accumulate in the heap, so reducing their size will allow more to accumulate before memory warnings.

Group the `BOOL`s into a struct. Shrink the various stored `enum`s to fit the size of their contents. Move the ivars around so that the smaller `enum` are near eachother and the bitfield struct.
    Greg Bolsinga committed May 3, 2019
    Configuration menu
    Copy the full SHA
    6ef8a23 View commit details
    Browse the repository at this point in the history

  2. address review comments. move enums out. add comment. rename struct t… 

    …o _flags
    Greg Bolsinga committed May 3, 2019
    Configuration menu
    Copy the full SHA
    4cc0829 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2019

  1. fix a missing rename

    Greg Bolsinga committed May 6, 2019
    Configuration menu
    Copy the full SHA
    817fd0d View commit details
    Browse the repository at this point in the history