CALayer: Set the default contentsScale to screen scale, update to match contents #1467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we hack this into ASImageNode but really it applies to any node.
Without this, if you're on a 2.0 screen and you set the content mode of a text to, say,
TopLeft
, the text will be twice its size i.e. rendered at 1.0, and you can only see the top left quarter of the contents.Basically, we are currently relying on
UIViewContentModeScaleToFill/kCAGravityResize
(the default) to apply our contentsScale. This is wrong and bad.UIView sets contents scale based on the screen, we should do the same thing on our own.
This is by no means the perfect state (we will still trample on a user-set value of contentsScale, but that's insanely rare) but it's better, and it's similar to how UIKit handles this.