Perform relayoutAllNodes (rotation, window resize) concurrently #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
requested review from
maicki,
garrettmoon,
appleguy,
nguyenhuy and
bolsinga
maicki
approved these changes
Apr 5, 2019
nguyenhuy
approved these changes
Apr 5, 2019
| // Ignore this element if it is no longer in the latest data. It is still recognized in the UIKit world but will be deleted soon. | ||
| NSIndexPath *indexPathInPendingMap = [_pendingMap indexPathForElement:element]; | ||
| if (indexPathInPendingMap == nil) { | ||
| continue; |
There was a problem hiding this comment.
Is this case uncommon and irrelevant now that we relayout concurrently?
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
@Adlai-Holler Can you rebase with master to unblock the CI? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes those operations run a lot faster.
Switching ASElementMap from NSMapTable to NSDictionary is necessary for this, but probably more efficient too. NSMapTable is pretty horrible (tons of extra memory allocations).