Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate a11y when layer change #1422

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

wsdwsd0829
Copy link
Contributor

@wsdwsd0829 wsdwsd0829 commented Mar 24, 2019

This cl solves following issues:

  1. frame not correct for custom actions.
  2. remove unnecessary container parameter in _ASDisplayViewAccessibliity.mm
  3. fix label for custom action not update after perform action that cause label changes.
  4. Invalidate a11y caches for voice over to update label.

The invaidateAccessibilityElements is needed for following cases:
when there is a accessibilityContainer in the tree we need to make sure it's invalidated whenever insert a view or layer.
If no accessibilityContainer involved, we still need to invalidate the first ancestor view to recollect new nodes.
Whenever layer backed nodes changes themselves like attributedText change.

#1274 is not a good fix cause when removing all caches will break the UIAccessibility's caching system and resulting in voice over cannot find next item with "swipe right". I will revert that experiment separately.

@ghost
Copy link

ghost commented Mar 25, 2019

🚫 CI failed with log

@ghost
Copy link

ghost commented Mar 25, 2019

🚫 CI failed with log

@ghost
Copy link

ghost commented Jul 17, 2019

🚫 CI failed with log

@nguyenhuy
Copy link
Member

@wsdwsd0829 Can you rebase with master one last time to unblock the CI?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants