Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Launches switching ASNetworkImageNode callbacks to global queue." #1382

Closed

Conversation

Adlai-Holler
Copy link
Member

@Adlai-Holler Adlai-Holler commented Mar 7, 2019

Reverts #1369

This is a pretty huge API change! I'm uncomfortable doing it so quietly. Some users undoubtedly do main-only things in these callbacks. For example, they might do if (self.hidden) { self.hidden = NO; } which would be accessing a bridged property off-main and boom.

I propose instead adding an opt-in class flag to trigger the feature. It's still an optional feature, it's just not an experimental one anymore. Like so:

// ASImageNode.h
AS_EXTERN void ASImageNodeEnableBackgroundCallbacks(void);

@wsdwsd0829
Copy link
Contributor

BTW, we had ASNetworkImageNode.useMainThreadDelegateCallbacks to optionally diable setting to NO. to control image delegate call backs.

@garrettmoon
Copy link
Member

I don't think this is an API change, it's used entirely internally as far as I can tell?

@Adlai-Holler
Copy link
Member Author

Oh, you're right, my bad! let's go forward with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants