Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ASCATransactionQueue #1350

Merged
merged 4 commits into from
Mar 6, 2019
Merged

Optimize ASCATransactionQueue #1350

merged 4 commits into from
Mar 6, 2019

Commits on Mar 3, 2019

  1. Optimize ASCATransactionQueue. This queue is very busy, and it runs o…

    …n the main thread so it's important for it to be fast.
    
    Avoid waking up the run loop for every single node.
    Avoid a ton of NSPointerArray overhead that we don't need.
    Avoid retain/release traffic on the singleton by using an inline function. I confirmed that in release mode, the static __strong is correctly inlined and no ARC traffic is incurred.
    Adlai-Holler committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    12a0911 View commit details
    Browse the repository at this point in the history
  2. Comment

    Adlai-Holler committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    f33e4c9 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. Unlock right

    Adlai-Holler committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    3b8ce0a View commit details
    Browse the repository at this point in the history
  2. Remove magic number

    Adlai-Holler committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    144fde4 View commit details
    Browse the repository at this point in the history