Remove duplicate definition of category "YogaDebugging" #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
changed the title
nguyenhuy
commented
Jan 30, 2019
Source/ASDisplayNode+Yoga.h
Outdated
| @@ -48,10 +48,6 @@ AS_EXTERN void ASDisplayNodePerformBlockOnEveryYogaChild(ASDisplayNode * _Nullab | |||
| /// For internal usage only | |||
| - (void)invalidateCalculatedYogaLayout; | |||
|
|
|||
| @end | |||
|
|
|||
| @interface ASDisplayNode (YogaDebugging) | |||
There was a problem hiding this comment.
The category is declared a few lines above.
There was a problem hiding this comment.
It seems like the naming is kind of off, sorry about that. Could you please update and keep YogaDebugging and instead rename YogaDebugging from above to YogaInternal? Thanks!
maicki
requested changes
Jan 30, 2019
Source/ASDisplayNode+Yoga.h
Outdated
| @@ -48,10 +48,6 @@ AS_EXTERN void ASDisplayNodePerformBlockOnEveryYogaChild(ASDisplayNode * _Nullab | |||
| /// For internal usage only | |||
| - (void)invalidateCalculatedYogaLayout; | |||
|
|
|||
| @end | |||
|
|
|||
| @interface ASDisplayNode (YogaDebugging) | |||
There was a problem hiding this comment.
It seems like the naming is kind of off, sorry about that. Could you please update and keep YogaDebugging and instead rename YogaDebugging from above to YogaInternal? Thanks!
nguyenhuy
force-pushed
the
HN-Duplicate-YogaDebugging
branch
from
3d204d3 to
03a7dc8
Compare
|
@maicki Done. |
Adlai-Holler
approved these changes
Feb 1, 2019
maicki
approved these changes
Feb 1, 2019
nguyenhuy
added a commit
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.