Set automaticallyAdjustsContentOffset to ASTableView when view is load #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Great catch! And thanks for fixing!
Would you mind updating our test suite to cover this bug as well? I'm looking at this line. It forces the node to load its view before setting automaticallyAdjustsContentOffset, which is why the test didn't catch this bug. Would be great if you change it to node.automaticallyAdjustsContentOffset = YES, which essentially tests if the property will be set to the view when it's loaded later.
maicki
approved these changes
Dec 11, 2018
|
@nguyenhuy I have updated the test suite and it passed |
|
Awesome. Thanks again. I’ll merge after CI finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before ASTableView is loaded, the property
automaticallyAdjustsContentOffsetis stored onpendingStatebut never set to view.This PR may fix this issue #23.