Move assertions so they are valid. #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PIN_ANIMATED is enabled, the creation of a PINRemoteImageManager will create a sharedDownloader also. Thus we cannot assert that it doesn't exist. We will move this assertion up to the methods that create the preconfiguredSharedManager and before said manager is allocated.
|
🚫 CI failed with log |
maicki
approved these changes
Dec 2, 2018
nguyenhuy
approved these changes
Dec 7, 2018
| @@ -131,7 +133,6 @@ + (void)setSharedImageManagerWithConfiguration:(nullable NSURLSessionConfigurati | |||
| + (void)setSharedPreconfiguredRemoteImageManager:(PINRemoteImageManager *)preconfiguredPINRemoteImageManager | |||
| { | |||
| NSAssert(preconfiguredPINRemoteImageManager != nil, @"setSharedPreconfiguredRemoteImageManager requires a non-nil parameter"); | |||
| NSAssert(sharedDownloader == nil, @"Singleton has been created and session can no longer be configured."); | |||
There was a problem hiding this comment.
But removing it here means I can get away with calling this method directly, even after a singleton was created? Having said that, I don't care that much tbh.
There was a problem hiding this comment.
It's true (if you managed to create a sharedDownloader but without a sharedPINRemoteImageManager, which will assert below) you could make your way through here and miss the asserts. It's definitely wrong as-is though.
|
@nguyenhuy Could you please restart the CI. Thanks! |
wsdwsd0829
pushed a commit
to wsdwsd0829/Texture
that referenced
this pull request
Mar 14, 2019
If PIN_ANIMATED is enabled, the creation of a PINRemoteImageManager will create a sharedDownloader also. Thus we cannot assert that it doesn't exist. We will move this assertion up to the methods that create the preconfiguredSharedManager and before said manager is allocated.
wsdwsd0829
pushed a commit
to wsdwsd0829/Texture
that referenced
this pull request
Mar 15, 2019
If PIN_ANIMATED is enabled, the creation of a PINRemoteImageManager will create a sharedDownloader also. Thus we cannot assert that it doesn't exist. We will move this assertion up to the methods that create the preconfiguredSharedManager and before said manager is allocated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PIN_ANIMATED is enabled, the creation of a PINRemoteImageManager
will create a sharedDownloader also. Thus we cannot assert that it
doesn't exist. We will move this assertion up to the methods that
create the preconfiguredSharedManager and before said manager is
allocated.