Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a thrash test suite for the collection node #1246

Merged
merged 12 commits into from
Jan 3, 2019
Merged

Start a thrash test suite for the collection node #1246

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3730f80
Split up table view thrash tests
mikezucc Nov 9, 2018
f0ff7c0
Fix license
mikezucc Nov 12, 2018
edd3c11
Fix license
mikezucc Nov 12, 2018
cab2df8
Reenable thrash tests for table view
mikezucc Nov 15, 2018
26f1ce0
Creating the collection view thrash tests
mikezucc Nov 19, 2018
1dbb74b
Batch update animated tests
mikezucc Nov 20, 2018
b31a529
Thrash wildly dispatch main
mikezucc Nov 20, 2018
a99f028
Reset the thrash count
mikezucc Nov 20, 2018
d29cb0e
One more test
mikezucc Dec 18, 2018
03c2a7e
Lint
mikezucc Dec 18, 2018
5d3d6fc
Update Tests/ASThrashUtility.h
nguyenhuy Dec 18, 2018
51bca64
Tiny code style change in ASCollectionViewThrashTests.mm
nguyenhuy Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reset the thrash count
  • Loading branch information
@mikezucc
mikezucc committed Nov 20, 2018
commit a99f028b274c6616983e2156e43456c3f856fa80
13 changes: 7 additions & 6 deletions Tests/ASCollectionViewThrashTests.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
//
// ASCollectionViewThrashTests.m
// AsyncDisplayKitTests
// ASTableViewThrashTests.mm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// ASTableViewThrashTests.mm
// ASCollectionViewThrashTests.mm

// Texture
//
// Created by Michael Zuccarino on 11/15/18.
// Copyright © 2018 Pinterest. All rights reserved.
// Copyright (c) Facebook, Inc. and its affiliates. All rights reserved.
// Changes after 4/13/2017 are: Copyright (c) Pinterest, Inc. All rights reserved.
// Licensed under Apache 2.0: http://www.apache.org/licenses/LICENSE-2.0
//

#import <XCTest/XCTest.h>
Expand Down Expand Up @@ -125,7 +126,7 @@ - (void)testThrashingWildlyDispatchWildly {
[self tearDown];
}

[self waitForExpectationsWithTimeout:60 handler:nil];
[self waitForExpectationsWithTimeout:100 handler:nil];
}

#pragma mark Helpers
Expand Down Expand Up @@ -176,7 +177,7 @@ - (void)applyUpdateUsingBatchUpdates:(ASThrashUpdate *)update
}

if (wait) {
[self waitForExpectationsWithTimeout:5 handler:nil];
[self waitForExpectationsWithTimeout:1 handler:nil];
}
}

Expand Down
7 changes: 4 additions & 3 deletions Tests/ASThrashUtility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
//
// ASThrashUtility.h
// ASTableViewThrashTests.mm
mikezucc marked this conversation as resolved.
Show resolved Hide resolved
// Texture
//
// Copyright (c) Pinterest, Inc. All rights reserved.
// Copyright (c) Facebook, Inc. and its affiliates. All rights reserved.
// Changes after 4/13/2017 are: Copyright (c) Pinterest, Inc. All rights reserved.
// Licensed under Apache 2.0: http://www.apache.org/licenses/LICENSE-2.0
//

Expand All @@ -16,7 +17,7 @@ NS_ASSUME_NONNULL_BEGIN
#define kMinimumItemCount 5
#define kMinimumSectionCount 3
#define kFickleness 0.1
#define kThrashingIterationCount 2
#define kThrashingIterationCount 100

// Set to 1 to use UITableView and see if the issue still exists.
#define USE_UIKIT_REFERENCE 0
Expand Down
5 changes: 3 additions & 2 deletions Tests/ASThrashUtility.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
//
// ASThrashUtility.m
// ASTableViewThrashTests.mm
// Texture
//
// Copyright (c) Pinterest, Inc. All rights reserved.
// Copyright (c) Facebook, Inc. and its affiliates. All rights reserved.
// Changes after 4/13/2017 are: Copyright (c) Pinterest, Inc. All rights reserved.
// Licensed under Apache 2.0: http://www.apache.org/licenses/LICENSE-2.0
//

Expand Down