Fix logic cleaning data if delegate / dataSource changes and bring over logic to ASTableView #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
force-pushed
the
ASTableViewCleanup
branch
from
213b10d to
5e8bc83
Compare
Adlai-Holler
approved these changes
Oct 29, 2018
maicki
force-pushed
the
ASTableViewCleanup
branch
from
5e8bc83 to
26912b9
Compare
maicki
force-pushed
the
ASTableViewCleanup
branch
from
26912b9 to
6751d7a
Compare
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
…er logic to ASTableView (TextureGroup#1200) * Cleanup in ASTableView datasource/delegate change * Fix experiments logic * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach we use to check if we should clear data if the dataSource / delegate changes via the
ASExperimentalClearDataDuringDeallocationflag has some issue. The problem is that we are checking_isDeallocatingand bail out if not true although we should only do that if the ASExperimentalClearDataDuringDeallocation flag is true.We have the same change within
ASCollectionView. We know from previous investigations (see #1155) that this currently can cause crashes. For consistency let's get this code over toASTableViewthough with the experiments setup we have withinASCollectionView.