Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't copy container during ASTextNode2 measure #1115

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Don't copy container during ASTextNode2 measure #1115

merged 1 commit into from
Sep 13, 2018

Conversation

Adlai-Holler
Copy link
Member

  • My previous change Reduce copying in ASTextNode2 stack #1065 intended for us to sometimes copy our mutable text container during layout.
  • It had a bug where we always copy the text container.
  • It turns out we never need to copy it, because we hold our lock while we use the container. We never mutate or retain the layout during measurement.

Copying text containers is surprisingly expensive hence I think this is worthwhile.

@Adlai-Holler Adlai-Holler changed the title Don't copy container during ASTextNode2 layout Don't copy container during ASTextNode2 measure Sep 12, 2018
@Adlai-Holler Adlai-Holler merged commit eb5bd09 into master Sep 13, 2018
@Adlai-Holler Adlai-Holler deleted the AHFixTenSixtyFive branch September 13, 2018 18:06
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
@Adlai-Holler @mikezucc
Don't copy container during ASTextNode2 layout (TextureGroup#1115)
b06844b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

@appleguy appleguy Awaiting requested review from appleguy

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adlai-Holler @maicki