Add an experimental flag to use native dispatch_apply (#1345)

* Add an experimental flag to use native dispatch_apply instead of our core count * 2 approach. This has shown performance wins in some profiling. * Add in other places
TextureGroup · Feb 21, 2019 · efeb3d2 · efeb3d2
1 parent 8edb5a4
commit efeb3d2
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 4 deletions.
diff --git a/Schemas/configuration.json b/Schemas/configuration.json
@@ -25,7 +25,8 @@
                     "exp_did_enter_preload_skip_asm_layout",
                     "exp_disable_a11y_cache",
                     "exp_skip_a11y_wait",
-                    "exp_new_default_cell_layout_mode"
+                    "exp_new_default_cell_layout_mode",
+                    "exp_dispatch_apply"
                 ]
     		}
 		}

diff --git a/Source/ASExperimentalFeatures.h b/Source/ASExperimentalFeatures.h
@@ -31,6 +31,7 @@ typedef NS_OPTIONS(NSUInteger, ASExperimentalFeatures) {
   ASExperimentalDisableAccessibilityCache = 1 << 10,        // exp_disable_a11y_cache
   ASExperimentalSkipAccessibilityWait = 1 << 11,            // exp_skip_a11y_wait
   ASExperimentalNewDefaultCellLayoutMode = 1 << 12,         // exp_new_default_cell_layout_mode
+  ASExperimentalDispatchApply = 1 << 13,                    // exp_dispatch_apply
   ASExperimentalFeatureAll = 0xFFFFFFFF
 };
 

diff --git a/Source/ASExperimentalFeatures.mm b/Source/ASExperimentalFeatures.mm
@@ -24,7 +24,8 @@
                                       @"exp_did_enter_preload_skip_asm_layout",
                                       @"exp_disable_a11y_cache",
                                       @"exp_skip_a11y_wait",
-                                      @"exp_new_default_cell_layout_mode"]));
+                                      @"exp_new_default_cell_layout_mode",
+                                      @"exp_dispatch_apply"]));
 
   if (flags == ASExperimentalFeatureAll) {
     return allNames;

diff --git a/Source/Private/ASDispatch.mm b/Source/Private/ASDispatch.mm
@@ -7,6 +7,8 @@
 //
 
 #import <AsyncDisplayKit/ASDispatch.h>
+#import <AsyncDisplayKit/ASConfigurationInternal.h>
+
 
 // Prefer C atomics in this file because ObjC blocks can't capture C++ atomics well.
 #import <stdatomic.h>
@@ -19,6 +21,10 @@
  */
 void ASDispatchApply(size_t iterationCount, dispatch_queue_t queue, NSUInteger threadCount, NS_NOESCAPE void(^work)(size_t i)) {
   if (threadCount == 0) {
+    if (ASActivateExperimentalFeature(ASExperimentalDispatchApply)) {
+      dispatch_apply(iterationCount, queue, work);
+      return;
+    }
     threadCount = NSProcessInfo.processInfo.activeProcessorCount * 2;
   }
   dispatch_group_t group = dispatch_group_create();

diff --git a/Tests/ASConfigurationTests.mm b/Tests/ASConfigurationTests.mm
@@ -30,7 +30,8 @@
   ASExperimentalDidEnterPreloadSkipASMLayout,
   ASExperimentalDisableAccessibilityCache,
   ASExperimentalSkipAccessibilityWait,
-  ASExperimentalNewDefaultCellLayoutMode
+  ASExperimentalNewDefaultCellLayoutMode,
+  ASExperimentalDispatchApply
 };
 
 @interface ASConfigurationTests : ASTestCase <ASConfigurationDelegate>
@@ -55,7 +56,8 @@ + (NSArray *)names {
     @"exp_did_enter_preload_skip_asm_layout",
     @"exp_disable_a11y_cache",
     @"exp_skip_a11y_wait",
-    @"exp_new_default_cell_layout_mode"
+    @"exp_new_default_cell_layout_mode",
+    @"exp_dispatch_apply"
   ];
 }