Fix Timer._timer_count to increment the class variable, not instance#6385
Closed
bysiber wants to merge 1 commit intoTextualize:mainfrom
Closed
Fix Timer._timer_count to increment the class variable, not instance#6385bysiber wants to merge 1 commit intoTextualize:mainfrom
bysiber wants to merge 1 commit intoTextualize:mainfrom
Conversation
self._timer_count += 1 reads the class variable (1), adds 1, and stores the result as an instance attribute. The class variable stays at 1 forever, so every auto-named timer gets "Timer#1". Use Timer._timer_count += 1 to modify the class variable directly, giving each timer a unique sequential name for debugging.
55d7a42 to
7bdffcd
Compare
Member
|
Your PR has been closed due to a AI policy violation. Please read the following before submitting further PRs. https://github.com/Textualize/textual/blob/main/AI_POLICY.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Timer._timer_countto actually increment the class variable instead of creating a shadowing instance attribute.Problem
In Python,
self._timer_count += 1reads the class variable (1), adds 1 (2), and stores the result as an instance attribute onself. The class variableTimer._timer_countis never modified — it stays at 1 forever.Every auto-named timer gets the name
"Timer#1".Fix
Use
Timer._timer_count += 1(explicit class reference) to modify the class variable directly.