Use os.get_terminal_size as the primary#6153
Open
wsxrdv wants to merge 1 commit intoTextualize:mainfrom
Open
Conversation
The function `shutil.get_terminal_size` returns environment variables `COLUMNS` and `LINES` when those exist. But this information is stale after resizing the terminal. First try to retrieve from `os.get_terminal_size` and only after fall back to `shutil`.
Author
|
Previous version of |
Author
|
This change allows proper reactivity to resize on Ubuntu inside tmux. One can also test these changes using the following script while resizing: import os
import shutil
import time
while True:
# os.get_terminal_size changes with resize
# shutil.get_terminal_size uses env variables (is constant)
print(f"{os.get_terminal_size() = } {shutil.get_terminal_size() = }")
time.sleep(1) |
Author
|
The Rich project also uses |
Author
|
I tried to dig deeper:
for d in ["LINES", "COLUMNS"]:
if d in os.environ:
del os.environ[d] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
shutil.get_terminal_sizereturns environment variablesCOLUMNSandLINESwhen those exist. But this information is stale after resizing the terminal. First try to retrieve fromos.get_terminal_sizeand only after fall back toshutil.Please review the following checklist.