Skip to content

test(footer): add pauses for flaky test in CI #6022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025
Merged

test(footer): add pauses for flaky test in CI #6022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc75cc2
test(footer): add pauses for flaky test in CI
TomJGooding Aug 6, 2025
fa55d14
chore: remove trailing spaces in Markdown CSS
TomJGooding Aug 6, 2025
0a5795d
chore: remove trailing spaces in Input CSS
TomJGooding Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/textual/widgets/_input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,8 @@ class Input(ScrollView):
}

&:focus {
border: tall $border;
border: tall $border;
background-tint: $foreground 5%;

}
&>.input--cursor {
background: $input-cursor-background;
Expand All @@ -212,12 +211,12 @@ class Input(ScrollView):
}
&.-invalid:focus {
border: tall $error;
}
}

&:ansi {
background: ansi_default;
color: ansi_default;
&>.input--cursor {
&>.input--cursor {
text-style: reverse;
}
&>.input--placeholder, &>.input--suggestion {
Expand All @@ -229,8 +228,7 @@ class Input(ScrollView):
}
&.-invalid:focus {
border: tall ansi_red;
}

}
}
}

Expand Down
50 changes: 23 additions & 27 deletions src/textual/widgets/_markdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ class MarkdownOrderedList(MarkdownList):

MarkdownOrderedList Vertical {
height: auto;
width: 1fr;
width: 1fr;
}
"""

Expand Down Expand Up @@ -607,29 +607,28 @@ class MarkdownTableContent(Widget):

DEFAULT_CSS = """
MarkdownTableContent {
width: 1fr;
width: 1fr;
height: auto;
layout: grid;
grid-columns: auto;
grid-rows: auto;
grid-gutter: 1 1;
layout: grid;
grid-columns: auto;
grid-rows: auto;
grid-gutter: 1 1;

& > .cell {
margin: 0 0;
height: auto;
padding: 0 1;
text-overflow: ellipsis;

}
& > .header {
height: auto;
margin: 0 0;
padding: 0 1;
color: $primary;
text-overflow: ellipsis;
content-align: left bottom;
text-overflow: ellipsis;
content-align: left bottom;
}
keyline: thin $foreground 20%;
keyline: thin $foreground 20%;
}
MarkdownTableContent > .markdown-table--header {
text-style: bold;
Expand Down Expand Up @@ -703,11 +702,11 @@ class MarkdownTable(MarkdownBlock):

DEFAULT_CSS = """
MarkdownTable {
width: 1fr;
margin-bottom: 1;
width: 1fr;
margin-bottom: 1;
&:light {
background: white 30%;
}
}
}
"""

Expand Down Expand Up @@ -796,7 +795,7 @@ class MarkdownBullet(Widget):
DEFAULT_CSS = """
MarkdownBullet {
width: auto;
color: $text-primary;
color: $text-primary;
&:light {
color: $text-secondary;
}
Expand Down Expand Up @@ -853,15 +852,15 @@ class MarkdownFence(MarkdownBlock):
scrollbar-size-horizontal: 0;
scrollbar-size-vertical: 0;
width: 1fr;
height: auto;
height: auto;
color: rgb(210,210,210);
background: black 10%;
&:light {
background: white 30%;
}
}
& > Label {
padding: 1 2;
}
}
}
"""

Expand Down Expand Up @@ -904,15 +903,15 @@ def compose(self) -> ComposeResult:

class Markdown(Widget):
DEFAULT_CSS = """
Markdown {
height: auto;
Markdown {
height: auto;
padding: 0 2 0 2;
layout: vertical;
color: $foreground;
color: $foreground;
overflow-y: hidden;

MarkdownBlock {
&:dark > .code_inline {
&:dark > .code_inline {
background: $warning 10%;
color: $text-warning 95%;
}
Expand All @@ -921,7 +920,7 @@ class Markdown(Widget):
color: $text-error 95%;
}
& > .em {
text-style: italic;
text-style: italic;
}
& > .strong {
text-style: bold;
Expand All @@ -930,10 +929,7 @@ class Markdown(Widget):
text-style: strike;
}
}

}


"""

BULLETS = ["• ", "▪ ", "‣ ", "⭑ ", "◦ "]
Expand Down
4 changes: 2 additions & 2 deletions tests/footer/test_footer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ def action_app_binding(self) -> None:
assert app_binding_count == 0
await app.wait_for_refresh()
await pilot.click("Footer", offset=(1, 0))
await app.wait_for_refresh()
await pilot.pause()
assert app_binding_count == 1
await pilot.click("Footer")
await app.wait_for_refresh()
await pilot.pause()
assert app_binding_count == 2
Loading