Add ANSI color for "brown"#4025
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4025 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 96 96
Lines 8370 8370
=======================================
Hits 8192 8192
Misses 178 178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is this definitely brown or a variant of dark orange? |
|
Right, according to this the code should be 94. |
|
I wonder what these ANSI color names were based on. It looks like 94 is already assigned to "orange4". I tried searching for some "official" reference without much luck - the closest I found was this list of Xterm colors: https://www.ditig.com/256-colors-cheat-sheet This seems to match the Rich colors at least from a quick check. But it looks like there isn't a "brown"! |
Damn, well I guess I can just remap "brown" to "orange4" then. |
Type of changes
AI?
AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.
Checklist
Description
Please describe your changes here.
Important: Link to an issue or discussion regarding these changes.