Skip to content

Add ANSI color for "brown"#4025

Closed
davidbrochart wants to merge 2 commits intoTextualize:masterfrom
davidbrochart:brown
Closed

Add ANSI color for "brown"#4025
davidbrochart wants to merge 2 commits intoTextualize:masterfrom
davidbrochart:brown

Conversation

@davidbrochart
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

AI?

  • AI was used to generate this PR

AI generated PRs may be accepted, but only if @willmcgugan has responded on an issue or discussion.

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate (see note about typos above).
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Please describe your changes here.

Important: Link to an issue or discussion regarding these changes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.87%. Comparing base (14a47c9) to head (8eeaa05).
⚠️ Report is 4 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4025   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files          96       96           
  Lines        8370     8370           
=======================================
  Hits         8192     8192           
  Misses        178      178           
Flag Coverage Δ
unittests 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomJGooding
Copy link
Contributor

Is this definitely brown or a variant of dark orange?

@davidbrochart
Copy link
Contributor Author

Right, according to this the code should be 94.

@TomJGooding
Copy link
Contributor

I wonder what these ANSI color names were based on. It looks like 94 is already assigned to "orange4".

I tried searching for some "official" reference without much luck - the closest I found was this list of Xterm colors: https://www.ditig.com/256-colors-cheat-sheet This seems to match the Rich colors at least from a quick check. But it looks like there isn't a "brown"!

@davidbrochart
Copy link
Contributor Author

It looks like 94 is already assigned to "orange4".

Damn, well I guess I can just remap "brown" to "orange4" then.
There might not be any official reference for ANSI colors, my "brown" came from pyte, and it looks like it mostly comes from console_codes(4).
Thanks for the review @TomJGooding!

@davidbrochart davidbrochart deleted the brown branch February 26, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants