Skip to content

Fix cell_len crash when string ends with ZWJ #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChimdumebiNebolisa wants to merge 2 commits into from
Closed

Fix cell_len crash when string ends with ZWJ #3952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ec5d29
style: format zwj cell_len regression test (refs #3947)
ChimdumebiNebolisa Feb 1, 2026
43f2094
fix: avoid StopIteration on trailing zero-width joiner (refs #3947)
ChimdumebiNebolisa Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion rich/cells.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,10 @@ def _cell_len(text: str, unicode_version: str) -> int:
for character in iter_characters:
if character in SPECIAL:
if character == "\u200d":
next(iter_characters)
try:
next(iter_characters)
except StopIteration:
break
elif last_measured_character:
total_width += last_measured_character in cell_table.narrow_to_wide
last_measured_character = None
Expand Down
8 changes: 8 additions & 0 deletions tests/test_zwj_cell_len.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from rich.cells import cell_len


def test_cell_len_zwj_does_not_raise() -> None:
cell_len("\u200d")
cell_len("a\u200d")
cell_len("a\u200d\n b")
cell_len("a\u200d b(")