Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RichHandler to include all flags of LogRender #182

Merged
merged 5 commits into from
Jul 29, 2020

Conversation

nathanrpage97
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

I saw a reference to this issue in #72.

Update the Console and RichHandler class to include show_time and show_level.

@nathanrpage97 nathanrpage97 marked this pull request as draft July 27, 2020 16:00
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          50       50           
  Lines        3786     3786           
=======================================
  Hits         3693     3693           
  Misses         93       93           
Flag Coverage Δ
#unittests 97.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/console.py 100.00% <ø> (ø)
rich/logging.py 97.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cefafdc...3e746dc. Read the comment docs.

@nathanrpage97 nathanrpage97 changed the title Update Console and RichHandler to include all flags of LogRender Update RichHandler to include all flags of LogRender Jul 27, 2020
@nathanrpage97 nathanrpage97 marked this pull request as ready for review July 27, 2020 16:33
@willmcgugan
Copy link
Collaborator

Thanks

@willmcgugan willmcgugan merged commit e33b3f6 into Textualize:master Jul 29, 2020
@ewels
Copy link
Contributor

ewels commented Jul 30, 2020

Nice, thanks both! I was about to come and request this feature 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants