QoL bugfixes #9
Open
QoL bugfixes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated log files have no place in a repository. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Within the whole system, uint32_t is used for the baudrate. We should do the same here to avoid implicit type conversions. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Resolves
/sdk/cc13xx_cc26xx_sdk/source/ti/zstack/npi/npi_tl.c:183:19: warning: passing 'Char[270]' (aka 'char[270]') to parameter of type 'uint8_t *' (aka 'unsigned char *') converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
transportInit(npiRxBuf,npiTxBuf, NPITL_transmissionCallBack);
^~~~~~~~
/sdk/cc13xx_cc26xx_sdk/source/ti/zstack/npi/npi_tl_uart.h:110:45: note: passing argument to parameter 'tRxBuf' here
void NPITLUART_initializeTransport(uint8_t *tRxBuf, uint8_t *tTxBuf, npiCB_t npiCBack);
^
/sdk/cc13xx_cc26xx_sdk/source/ti/zstack/npi/npi_tl.c:183:28: warning: passing 'Char[270]' (aka 'char[270]') to parameter of type 'uint8_t *' (aka 'unsigned char *') converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
transportInit(npiRxBuf,npiTxBuf, NPITL_transmissionCallBack);
^~~~~~~~
/sdk/cc13xx_cc26xx_sdk/source/ti/zstack/npi/npi_tl_uart.h:110:62: note: passing argument to parameter 'tTxBuf' here
void NPITLUART_initializeTransport(uint8_t *tRxBuf, uint8_t *tTxBuf, npiCB_t npiCBack);
^
2 warnings generated.
Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small number of inconsistency fixes