Open
Conversation
DhruvaG2000
force-pushed
the
2core_s2idle
branch
2 times, most recently
from
96de801 to
dca9c43
Compare
Enable mode selection b/w deep sleep and rtc ddr mode with s2idle along with both the cores running. Signed-off-by: Dhruva Gole <d-gole@ti.com>
Add an API for per-cpu gic restoration during suspend/resume Signed-off-by: Dhruva Gole <d-gole@ti.com>
these helpers can be used across the PSCI driver to help locally turn on/off cores without using the callbacks that are used by the core PSCI fw. Signed-off-by: Dhruva Gole <d-gole@ti.com>
Delay the core 1 pwr on sequence for s2idle after interrupt (IPI) arrives from the other core signalling that it is ready to bring back the other CPU Signed-off-by: Dhruva Gole <d-gole@ti.com>
DhruvaG2000
force-pushed
the
2core_s2idle
branch
from
dca9c43 to
340d71a
Compare
ti-sebin
reviewed
Feb 12, 2026
plat/ti/k3/common/am62l_psci.c
Outdated
| write_scr_el3(scr); | ||
| } | ||
|
|
||
| static int __maybe_unused am62l_loc_pwr_on(int core) { |
ti-sebin
reviewed
Feb 12, 2026
| am62l_lpm_state = LPM_MODE_RTC_DDR; | ||
| } else if (power_state == LPM_STATE_SECONDARY_CPU_SUSPEND) { | ||
| /* | ||
| * Secondary CPU suspend marker. Only set a default if |
There was a problem hiding this comment.
So id this race condition occurs, it always enter deepsleep or it get overwritten?
|
|
||
| if (core == 1) { | ||
| INFO("!!GIC restore \n"); | ||
| k3_gic_pcpu_restore(); |
| core1_timeout--; | ||
| } while (core1_timeout > 0); | ||
|
|
||
| if (core1_timeout == 0) |
There was a problem hiding this comment.
Why we need timeout? If the kernel is not excepting the core 1 to be on why we need to wake it up? Also, what happens is there is any interrupt that had affinity to core 1 has occurred? Can we have some info in this aspect as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable mode selection b/w deep sleep and rtc ddr mode with s2idle along with both the cores running.