feat: Auto-select containers created during export + LDAP paging fix for Samba AD #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements two related features:
1. **Partition/Container Validation**
- Add `HasPartitionsOrContainersSelected()` extension method to check
if a Connected System has required partition/container selections
- Add warning on Partitions & Containers tab when nothing is selected
- Disable Object Matching and Run Profiles tabs until selections made
- Validate partition selections when creating worker tasks
- Return error or warning based on configurable PartitionValidationMode
- API returns 400 Bad Request for Error mode, includes warnings in response
2. **Service Settings Refactor (Discourse-style)**
- New ServiceSetting entity with metadata (Category, Description,
DefaultValue, IsReadOnly, IsSecret, EnumTypeName)
- ServiceSettingCategory enum (SSO, Synchronisation, Maintenance, History)
- ServiceSettingValueType enum (String, Boolean, Integer, TimeSpan, Enum)
- PartitionValidationMode enum (Error, Warning) with Error as default
- Repository layer for ServiceSetting CRUD operations
- ServiceSettingsServer with typed value retrieval and update methods
- All setting modifications create Activity records for audit trail
- Seed default settings from environment variables on startup
- Admin UI at /admin/settings with search, category grouping,
show/hide secrets, edit dialog, and revert to default
Files added:
- JIM.Models/Core/ServiceSetting.cs
- JIM.Models/Tasking/DTOs/WorkerTaskCreationResult.cs
- JIM.PostgresData/Migrations/20251229163327_AddServiceSettingEntity.cs
- JIM.Web/Pages/Admin/Settings.razor
- JIM.Web/Shared/EditSettingDialog.razor
Files modified:
- Multiple files across Application, Data, Models, PostgresData, and Web
Tests: 790 passing (including 14 new tests for the extension method)
Closes #229 (GitHub issue created for sequential tab workflow as follow-up)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…tion tests
Updates integration tests to properly test partition/container selection:
1. **Populate-SambaAD.ps1**: Creates "Borton Corp" base OU in Samba AD
- Users will be provisioned under /Borton Corp/{Department}/
- Department OUs are created dynamically by the LDAP connector
- Legacy root-level department OUs kept for backward compatibility
2. **Setup-Scenario1.ps1**: Adds Step 6a for hierarchy import and selection
- Imports LDAP partition/container hierarchy
- Selects the testdomain partition
- Selects the Borton Corp container
- This tests the partition validation feature implemented earlier
3. **DN Expression Update**: Changed from:
`OU={Department},DC=testdomain,DC=local`
to:
`OU={Department},OU=Borton Corp,DC=testdomain,DC=local`
This enables testing:
- Partition hierarchy retrieval (Import-JIMConnectedSystemHierarchy)
- Container selection (Set-JIMConnectedSystemContainer)
- Partition validation enforcement
- Dynamic OU creation by the LDAP connector
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The PageResultRequestControl was marked as critical by default, causing delta imports to fail on Samba AD which doesn't support paging. Making it non-critical allows servers that don't support paging to ignore the control and return all results at once, while servers with paging support continue to work normally. Changes: - LdapConnectorImport.cs: Set IsCritical = false for both full and delta import paging controls (lines 318 and 374) This enables the auto-select containers feature to work with Samba AD during integration testing. All 6 integration tests now pass: ✓ Joiner, Mover, Mover-Rename, Mover-Move, Leaver, Reconnection 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 4: Auto-Select Containers Created During Export
Fix: LDAP Paging Control Compatibility
PageResultRequestControlnon-critical to work with Samba ADImplementation
Part 4: Auto-Select Containers
IConnectorContainerCreation- for connectors that create containers during exportLdapConnectorExportSyncExportTaskProcessortriggersRefreshAndAutoSelectContainersAsync()Key Files:
JIM.Models/Interfaces/IConnectorContainerCreation.cs(NEW)JIM.Connectors/LDAP/LdapConnectorExport.cs- tracks created containersJIM.Connectors/LDAP/LdapConnector.cs- implementsIConnectorContainerCreationJIM.Application/Servers/ConnectedSystemServer.cs-RefreshAndAutoSelectContainersAsync()methodJIM.Worker/Processors/SyncExportTaskProcessor.cs- post-export hookJIM.Worker/Worker.cs- passes WorkerTask to export processor for initiator infoLDAP Paging Fix
File:
JIM.Connectors/LDAP/LdapConnectorImport.csIsCritical = falseIsCritical = falseTest Results
✅ All 792 unit tests pass
✅ All 6 integration tests pass:
Trade-offs & Compatibility
The non-critical paging control change:
Post-MVP Enhancement
Created GitHub issue #231 for dynamic capability detection to query RootDSE and only use paging when supported, providing explicit visibility into server capabilities.
Checklist
dotnet build JIM.sln- Successdotnet test JIM.sln- 792 tests pass