Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible race-condition #38

Closed
TetrisIQ opened this issue Feb 23, 2022 · 0 comments · Fixed by #39
Closed

Possible race-condition #38

TetrisIQ opened this issue Feb 23, 2022 · 0 comments · Fixed by #39
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@TetrisIQ
Copy link
Owner

Describe the bug
I think there is a possible race-condition, when multiple persons trying to write data (answer the poll). Information about some Participants can be overwritten.

To Reproduce
Hard to reproduce, I'm not sure if this is a valid point.

Additional context
The way the app writes data to the network is not the best. It's better if we have update methods for every attribute. This means that we cannot encrypt the hole PollDTO Object, so we could encrypt only the values of (for example: participants) and map them as a key value map, with the name of the Participant.
In this way, we can update one Participant without overriding the hole object.

This is a much better implementation

@TetrisIQ TetrisIQ added bug Something isn't working enhancement New feature or request labels Feb 23, 2022
@TetrisIQ TetrisIQ self-assigned this Feb 23, 2022
TetrisIQ added a commit that referenced this issue Feb 25, 2022
TetrisIQ added a commit that referenced this issue Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant