The PR checker should check DeveloperFixed Notes #295
Conversation
pthariensflame
force-pushed
the
patch-3
branch
from
91af593 to
7077fe9
Compare
winglam
left a comment
winglam
left a comment
There was a problem hiding this comment.
Thanks for your changes!
format_checker/pr_checker.py
Outdated
There was a problem hiding this comment.
This line and Line 123 can be combined
There was a problem hiding this comment.
Better yet you can simply add row["Status"] == "DeveloperFixed" to Line 126 (Line 128 can then be triggered only for row["Status"] == "") and remove this whole if block
format_checker/pr_checker.py
Outdated
There was a problem hiding this comment.
I assume that the desire to require Notes for DeveloperFixed status is to have people provide the information for when a flaky test was fixed.
Although, it is certainly nice if people would provide Notes detailing when the developer fixed a particular flaky test, I don't envision that being easy for most to provide. E.g., for someone that runs some flaky test detection tool on the latest version of the project and finds that a particular flaky test is no longer flaky, we do not want to limit the contribution of such information only if that person provides Notes to describe when the test is fixed by the developer.
Unless there are other reasons to add this requirement, I suggest removing this change from this PR.
Previously this wasn't happening, as visible in TestingResearchIllinois#294.
pthariensflame
force-pushed
the
patch-3
branch
from
7077fe9 to
67a0479
Compare
2 participants
Previously this wasn't happening, as visible in #294.