feat: create campaign main page #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Esinko
commented
May 18, 2023
Esinko
commented
- Include to-be-donated devices' technical information and images
- Include placeholders for applying for a donation
- Include some basic campaign information
- Include to-be-donated devices' technical information and images - Include placeholders for applying for a donation - Include some basic campaign information
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Eldemarkki
suggested changes
May 18, 2023
ahnl
previously requested changes
May 18, 2023
- The device element now aligns content top-bottom when side-side is not possible within element bounds - Includes some minor refactoring
- Removes extra margin from gallery image selection while under 776px (left margin)
- Changes campaign page name to computer-sharing.tsx - Fixed typo in image asset name - Content typos fixed
Esinko
dismissed
ahnl’s stale review
Now resolved. Dunno how to properly address this.
|
Pikkupräntti/ehdot vois tuoda sivun pohjalta ylös jossa ne on helposti luettavissa |
|
Lisää keskustelua ja ideointia kampanjasta lauantaina 27.5. #yhdistys-kanavalla: |
Eldemarkki
suggested changes
Jun 9, 2023
|
Will merge now. Further changes should be done through PRs towards the coal branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.