Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses SonarCloud issues by refactoring code to eliminate static analysis warnings. The changes focus on improving code quality without altering functionality.
Changes:
- Removed redundant multiplication by zero in timer configurations
- Replaced
GetCustomAttribute<T>()with more efficientIsDefined()calls - Added pragma directives to suppress unavoidable SonarCloud warnings for complexity and parameter count
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tests/Testably.Abstractions.Tests/TimeSystem/TimerTests.cs | Fixed timer delays by removing multiplication by zero |
| Tests/Testably.Abstractions.Testing.Tests/Statistics/StatisticsTests.Helpers.cs | Optimized obsolete attribute checking using IsDefined() |
| Source/Testably.Abstractions.Testing/Statistics/CallStatistics.cs | Suppressed parameter count warning for method with 7 parameters |
| Source/Testably.Abstractions.Testing/FileSystem/FileStreamMock.cs | Suppressed cognitive complexity warning for constructor |
Test Results 52 files ±0 52 suites ±0 34m 15s ⏱️ -19s For more details on these failures, see this check. Results for commit 359e6f5. ± Comparison against base commit 68305d1. This pull request removes 55342 and adds 55342 tests. Note that renamed tests count towards both.This pull request removes 2920 skipped tests and adds 2920 skipped tests. Note that renamed tests count towards both. |
|
|
This is addressed in release v5.0.3. |
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses SonarCloud issues by refactoring code to eliminate static analysis warnings. The changes focus on improving code quality without altering functionality.
Key Changes:
GetCustomAttribute<T>()with more efficientIsDefined()calls