Skip to content

fix: correctly handle readonly directories during delete #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2025
Merged

fix: correctly handle readonly directories during delete #854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4da05d4
fix: correctly handle readonly directories during delete
vbreuss Sep 10, 2025
c2e4eee
Fix path on .NET Framework
vbreuss Sep 10, 2025
9117453
Merge branch 'main' into topic/handle-readonly-directories
vbreuss Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Source/Testably.Abstractions.Testing/Storage/InMemoryContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ public IStorageAccessHandle RequestAccess(FileAccess access, FileShare share,
!ignoreMetadataErrors &&
Attributes.HasFlag(FileAttributes.ReadOnly))
{
throw ExceptionFactory.AccessToPathDenied();
throw ExceptionFactory.AccessToPathDenied(_fileSystem.Execute.IsNetFramework
? _location.FriendlyName
: _location.FullPath);
}
#if FEATURE_FILESYSTEM_UNIXFILEMODE
if (!deleteAccess && !_fileSystem.UnixFileModeStrategy
Expand Down
1 change: 1 addition & 0 deletions Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ public bool DeleteContainer(
location);

using (container.RequestAccess(FileAccess.Write, FileShare.ReadWrite,
ignoreMetadataErrors: false,
deleteAccess: true))
{
if (_containers.TryRemove(location, out IStorageContainer? removed))
Expand Down
21 changes: 21 additions & 0 deletions Tests/Testably.Abstractions.Tests/FileSystem/Directory/DeleteTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,27 @@ await That(Act).Throws<DirectoryNotFoundException>()
.WithHResult(-2147024893);
}

[Theory]
[AutoData]
public async Task Delete_ReadonlyDirectory_ShouldThrowIOExceptionOnWindows(string path)
{
IDirectoryInfo sut = FileSystem.Directory.CreateDirectory(path);
sut.Attributes = FileAttributes.ReadOnly;
sut.Refresh();

void Act()
{
FileSystem.Directory.Delete(path);
}

await That(Act).Throws<IOException>()
.OnlyIf(Test.RunsOnWindows)
.WithMessage(Test.IsNetFramework
? $"Access to the path '{path}' is denied."
: $"Access to the path '{sut.FullName}' is denied.").And
.WithHResult(-2146232800);
}

[Theory]
[AutoData]
public async Task Delete_Recursive_MissingDirectory_ShouldThrowDirectoryNotFoundException(
Expand Down
21 changes: 21 additions & 0 deletions Tests/Testably.Abstractions.Tests/FileSystem/DirectoryInfo/DeleteTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,27 @@ await That(Act).Throws<DirectoryNotFoundException>()
.WithHResult(-2147024893);
}

[Theory]
[AutoData]
public async Task Delete_ReadonlyDirectory_ShouldThrowIOExceptionOnWindows(string path)
{
IDirectoryInfo sut = FileSystem.Directory.CreateDirectory(path);
sut.Attributes = FileAttributes.ReadOnly;
sut.Refresh();

void Act()
{
sut.Delete();
}

await That(Act).Throws<IOException>()
.OnlyIf(Test.RunsOnWindows)
.WithMessage(Test.IsNetFramework
? $"Access to the path '{path}' is denied."
: $"Access to the path '{sut.FullName}' is denied.").And
.WithHResult(-2146232800);
}

[Theory]
[AutoData]
public async Task Delete_Recursive_WithOpenFile_ShouldThrowIOException_OnWindows(
Expand Down
Loading