fix: null-handling in Wrap-Method in factories for IDirectoryInfo or IFileInfo
#976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
approved these changes
Apr 23, 2023
Contributor
fgreinacher
left a comment
fgreinacher
left a comment
There was a problem hiding this comment.
Looks great, thanks for the quick fix!
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
…FileSystemWatcher` (#977) Building on #976 also fix null-handling for DriveInfo and FileSystemWatcher factories: When providing null as parameter to the implementations of IDriveInfoFactory or IFileSystemWatcherFactory return null instead of throwing an exception. This extends the issue reported in #975 to other factories used in System.IO.Abstractions.
|
This is addressed in release v19.2.17. |
vbreuss
referenced
this pull request
in Testably/Testably.Abstractions
Apr 25, 2023
…19.2.18 (#301) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions) | nuget | patch | `19.2.16` -> `19.2.18` | --- ### Release Notes <details> <summary>TestableIO/System.IO.Abstractions</summary> ### [`v19.2.18`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.18) #### What's Changed - fix: null-handling in Wrap-Method in factories for `IDriveInfo` or `IFileSystemWatcher` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/TestableIO/System.IO.Abstractions/pull/977](https://togithub.com/TestableIO/System.IO.Abstractions/pull/977) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.17...v19.2.18 ### [`v19.2.17`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v19.2.17) ##### What's Changed - fix: null-handling in Wrap-Method in factories for `IDirectoryInfo` or `IFileInfo` by [@​vbreuss](https://togithub.com/vbreuss) in [https://github.com/TestableIO/System.IO.Abstractions/pull/976](https://togithub.com/TestableIO/System.IO.Abstractions/pull/976) **Full Changelog**: TestableIO/System.IO.Abstractions@v19.2.16...v19.2.17 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTguMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #975:
When providing
nullas parameter to the implementations ofIFileInfoFactoryorIDirectoryInfoFactoryreturnnullinstead of throwing an exception.