feat: Add temp path overload for DisposableFileSystem extensions#63
Merged
gigi81 merged 1 commit intoTestableIO:mainfrom Feb 26, 2024
Merged
Conversation
Collaborator
|
Hi @MattKotsenas |
Contributor
Author
|
Hi there! The new 3 parameter overloads call the old 4 parameter overloads, so from a coverage perspective they are covered. From a pedantic perspective, we could add a test to make sure the Let me know what you prefer! |
Collaborator
|
agreed. thanks. merging now. |
|
This is addressed in release v2.2.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CreateDisposableFile/CreateDisposableDirectoryextensions provide two overloads, one automatically creates a subdirectory under%TEMP%, and the other takes astring.However, the overload that accepts a disposable factory only has one overload that requires a path. In order to make using the extension with custom disposables easier, also provide an overload that automatically creates a subdirectory under
%TEMP%.Also updated unit tests to cover the functionality.