feat: IDirectoryInfo.CopyTo#19
Merged
gigi81 merged 11 commits intoTestableIO:feature/copyto-18from Jan 8, 2023
Merged
Conversation
Added an Extension Method to IDirectoryInfo to recursively copy a directory.
Added Example for IDirectoryInfo.CopyTo extension
Fixed "Deprecated" warings from version 17.X
Update Readme to 17.X
Closed
gigi81
reviewed
Dec 16, 2022
src/System.IO.Abstractions.Extensions/IDirectoryInfoExtensions.cs
Outdated
Show resolved
Hide resolved
gigi81
reviewed
Dec 16, 2022
src/System.IO.Abstractions.Extensions/IDirectoryInfoExtensions.cs
Outdated
Show resolved
Hide resolved
gigi81
reviewed
Dec 16, 2022
src/System.IO.Abstractions.Extensions/IDirectoryInfoExtensions.cs
Outdated
Show resolved
Hide resolved
Collaborator
|
hi @mayermart thanks for your PR. please have a look at my comments |
gigi81
reviewed
Dec 16, 2022
Reordered Methods. Removed throw if destination exists. Usage of IFileSystem
Contributor
Author
|
Hi @gigi81, thanks for your feedback. Actually i can't remember why i implemented the throw if the destination already exists. Its not even in the template from MS. |
Collaborator
|
Thanks! Will review later! |
Collaborator
|
Merging this into a feature branch as there are still some bits I'm not totally convinced and I want to fix before merging into main. Thanks for your contribution |
gigi81
added a commit
that referenced
this pull request
Aug 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
i implemented a first draft for IDirectoryInfo.CopyTo for recursively copying an IDirecotyInfo to a new path.
There are two possible usages:
IDirectoryInfo IDirectoryInfo.CopyTo(string destDirectoryName, bool recursive)andIDirectoryInfo IDirectoryInfo.CopyTo(IDirectoryInfo destDirectory, bool recursive)Please take a look and provide some feedback :-)
This closes #18