Skip to content

Evaluate the HTML Controls #134

Open
@robdmoore

Description

@robdmoore
  • controlId is fairly inconsistent with the other ways of searching in Seleno (as mentioned in More love for the bare-ui-test users #88)
  • Having to specify the type of control is helpful in some ways (the test might be more readable in some circumstances where understanding the HTML structure helps give light to how the UI is being interacted with), but in others it is a detail you shouldn't need to worry about and could make the test more brittle if you change your UI. It's possible to detect the control using Selenium WebDriver and something like Being able to fill in a single strongly-typed field using same algorithm as Input.Model #133 would largely render parts of the controls pointless.
  • The method names are fairly confusing (the way you interact with the control varies quite a lot across the controls) and there are multiple ways of getting the controls (HtmlControlFor as well as ) so it might be worth looking at that
  • Using jQuery is great in that it always sets the values, but it causes problems like events not firing and will work even when the element isn't visible - this needs to be reviewed

I don't think we should get rid of them by any means, but I do think we need to look at the above points and assess what changes we want to make to the controls before 1.0.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions