Skip to content

Brought in ExpressionToString #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2015
Merged

Brought in ExpressionToString #57

merged 4 commits into from
Apr 8, 2015

Conversation

AlexArchive
Copy link
Contributor

Implementation of #54.

@AlexArchive
Deleted ExpressionInspectorTests
a358f1a 
Usually it makes sense to only test the public Api but at the time, I came
to the conclusion that these tests were just.

Now that we are going to be dependent on the ExpressionToString package,
it makes no sense to test their code.
@AlexArchive
Brought in ExpressionToString
06c6fc0 
- Amended tests to conform to breaking changes introduced by
  ExpressionToString.
- Deleted ExpressionInspector class as it is no longer needed.
@AlexArchive
Documented breaking change
27b5209
@AlexArchive
Tweaked ExpressionStringBuilder to support Xor and Coalesce operators
a13eadd 
This is a temporary solution.

I will create a pull request to ExpressionToString and then update the
package here.
@AlexArchive
Copy link
Contributor Author

Please review, @robdmoore.

@AlexArchive
Copy link
Contributor Author

I ran ExpressionToString against my now-deleted ExpressionInspector tests. They almost all passed. The only two that did not were ones who used the ?? and ^ operators. This is because ExpressionToString does not yet support them. I added a temporary fix in this pull request, but this approach is not ideal as any future updates to ExpressionToString will over-write my changes. I have already submitted a pull request to circumvent this potential threat. Because the implementation is the same, users should not notice any breaking changes.

I am happy to release 3.0.0 now if you are.

@robdmoore
Copy link
Member

Looks good. Feel free to merge.

On 8 Apr 2015, at 6:35 pm, Null notifications@github.com wrote:

Implementation of #54.

You can view, comment on, or merge this pull request online at:

#57

Commit Summary

Deleted ExpressionInspectorTests
Brought in ExpressionToString
Documented breaking change
Tweaked ExpressionStringBuilder to support Xor and Coalesce operators
File Changes

M BREAKING_CHANGES.md (24)
D TestStack.FluentMVCTesting.Tests/Internal/ExpressionInspectorTests.cs (174)
M TestStack.FluentMVCTesting.Tests/TestStack.FluentMVCTesting.Tests.csproj (1)
M TestStack.FluentMVCTesting.Tests/ViewResultTestTests.cs (17)
A TestStack.FluentMvcTesting/App_Packages/ExpressionStringBuilder.0.9.2/ExpressionStringBuilder.cs (283)
D TestStack.FluentMvcTesting/Internal/ExpressionInspector.cs (16)
M TestStack.FluentMvcTesting/Properties/AssemblyInfo.cs (3)
M TestStack.FluentMvcTesting/TestStack.FluentMVCTesting.csproj (2)
M TestStack.FluentMvcTesting/ViewResultTest.cs (5)
M TestStack.FluentMvcTesting/packages.config (1)
Patch Links:

https://github.com/TestStack/TestStack.FluentMVCTesting/pull/57.patch
https://github.com/TestStack/TestStack.FluentMVCTesting/pull/57.diff
—
Reply to this email directly or view it on GitHub.

AlexArchive pushed a commit that referenced this pull request Apr 8, 2015
Merge pull request #57 from ByteBlast/master
00ce004 
Brought in ExpressionToString
@AlexArchive AlexArchive merged commit 00ce004 into TestStack:master Apr 8, 2015
@AlexArchive
Copy link
Contributor Author

Awesome.

Please push ver. 3.0.0 to NuGet when you have time.

@robdmoore
Copy link
Member

Done ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexArchive @robdmoore