Consistent error messages #55
Conversation
|
I had intended to make the wording more consistent but I changed my mind. Can you please review and if it looks good, merge, @robdmoore? Thank you. |
|
I know you have been busy moving house etc. (congratulations by the way:balloon:) so just to remind you in case you forgot: We are sitting on version 3.0.0 at the moment. When I implement #54 I will kindly ask you to publish version 3.0.0. Please do not publish the new package yet. Cheers. |
|
When your notifications come through on email your name is "null" FYI. Not sure if deliberate :P |
| } | ||
|
|
||
| [Test] | ||
| _controller.ShouldHaveTempDataProperty(key)); |
There was a problem hiding this comment.
Why is the diff so big? Is there whitespace changes?
There was a problem hiding this comment.
Think so. I will double check if you cannot. I am working on #54 at the moment.
|
Yeah, it is. |
|
Happy for you to merge this. Might be worth seeing if you can stop the whitespace changes though? |
Reconciled quotation marks
Work in progress.