-
Notifications
You must be signed in to change notification settings - Fork 18
Adds a Set overload which takes a lambda factory method #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bf636b8
Adds a Set overload which takes a lambda factory method
6eaee0b
Fixes up the set lambda, the function pattern now underlies other met…
Quantumplation 0d13e75
Fixes a doc comment
Quantumplation 3b4bc63
Added the start of a contributor guidelines file
Quantumplation 1d1d47d
Fixes a stylistic issue with ifs and statements on the same line
Quantumplation File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
Contributor Guidelines | ||
====================== | ||
|
||
Hi! Thank you for your interest in contributing to this open source library! | ||
We ask that you follow the following style guidelines when submitting pull | ||
requests, to keep the code consistent and maintainable. | ||
|
||
- Do not put an if clause and it's statement on the same line: separate them | ||
with a new-line and indent accordingly. | ||
|
||
(This file will be expanded as more guidelines are established by the maintainer) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also wanted to provide an overload that would take a lambda Func from TObj to TValue, so that you could base your value on the partially constructed object (i.e. make sure that AmountPaid was less than AmountOwed, or something),but that would have required too much internal structuring, so I left it for another day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be too hard to do the partially constructed object, you could do one that takes the builder so you can use a
Get
call though?