Skip to content

Added implicit creation of entities for the ultimate in terseness #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2015
Merged

Conversation

mwhelan
Copy link
Member

@mwhelan mwhelan commented Apr 22, 2015

Adds choice to user whether or not to call Build() and BuildList() to create test data.
Leaving them off is the ultimate in terseness!

@robdmoore
Copy link
Member

Looks good. Only concern is that this has the potential to be confusing for people. But happy to put it in there and see what happens.

Can you bump minor in nextversion.txt?

@mwhelan
Copy link
Member Author

mwhelan commented Apr 23, 2015

Awesome! I was quite excited to wake up this morning and find out what you
thought! :-)

Was a great experience implementing it by the way. Just applied your tests
implicitly and they pointed out I needed to implement List on
TestDataBuilder as well as ListBuilder. Very cool.

Have bumped to 2.1.

Thanks
Michael

On Thu, Apr 23, 2015 at 2:01 AM, Rob Moore notifications@github.com wrote:

Looks good. Only concern is that this has the potential to be confusing
for people. But happy to put it in there and see what happens.

Can you bump minor in nextversion.txt?


Reply to this email directly or view it on GitHub
#29 (comment)
.

robdmoore added a commit that referenced this pull request Apr 23, 2015
Added implicit creation of entities for the ultimate in terseness
@robdmoore robdmoore merged commit 7ce4bb3 into TestStack:master Apr 23, 2015
@mwhelan
Copy link
Member Author

mwhelan commented Apr 26, 2015

This closes #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants