Fixes IsStatic() extension method. #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for this. Would you have time to drop a test in as well for this, it would be handy to increase our test coverage on these sort of utilities. let me know either way |
|
I have just pushed v3, I will push 3.0.1 once this gets pulled in. Let me know if you plan on adding the test :) |
|
Okay, I've thrown together some quick tests. Hope that will at least give you a starting point. |
|
How is this issue coming along? |
|
Thanks for reminding me, will get it released soon! |
|
Ugh regions, but not gonna stop this getting released because of that :P |
|
Sorry for taking so long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with IsStatic() extension method.