Conversation
|
Thanks for creating this here @JakeGinnivan. FWIW this is a spike with a fair bit of ugly code and hack and pretty much no test coverage. |
|
That is fine, we can keep going forward adding tests and cleaning it up. We can just submit small PR's targeting this branch to keep reviewing changes small, and that way we can add tasks to the PR and anyone can jump in and take a small part |
|
If we learn stuff, and want to start again instead, we can kill this and bring up another PR |
…s available. (args which use _.)
Step execution with errors
Updated markdown report for examples
|
Actually, is not an issue. I think it is just the test runner picking it up from multiple places |
Format line feed in text reporter
…ll inject the example value into the local variable
…well as the parameter name matching
Buying train tickets example
…lders Can now declare a local variable inside the test method, and BDDfy will ...
|
I also think we have backfilled a lot of tests, I am not sure of any test cases to add (as I have found issues I have added tests). I think basically the changes to the executable step scanner, and updating the diagnostics report is all we have to do. Thoughts @MehdiK @mwhelan @robdmoore ? If anyone has time to give this stuff a spin to try and find issues that would be awesome.. |
|
Thanks for finding it. Hmmm, it's a funny combination, ay? Will check it out. |
|
@MehdiK I'm not sure it is even a valid combination. But at a minimum if the attribute exists, throw an exception saying to report your scenario? :) |
|
But to make a test fail, do this to |
|
That definitely not going to work; but I was thinking about a potential valid combination of |
|
Agreed about the exception on invalid combination. |
|
OH YEEEEEEEEAAAAAAAH!! Thanks mate for the awesome work on this PR. |
|
When using the Metro style, example table is not displayed in the report. // to change to metro style |
|
@isaldarriaga can you open a fresh issue? |
|
Sure |
Fixes #15
Outstanding work:
WithExampleswith tabular verbatim string example?GivenTheForceIs(ForceLevel)should have step name ofGiven the force level is <force level>if there is an example with Header ofForce LevelGivenTheForceIs__ForceLevel__