Conversation
|
@jason-roberts would be great if you could update your Metro report to do the same thing as this :) |
|
We need to merge that work in and then rebase the whole example feature on top of that. |
|
Thanks @JakeGinnivan. This is quite exciting :) I haven't looked at this yet. Will check it out hopefully tomorrow. There are some failing approval tests on CI. |
|
😠
|
|
Yeah I got that, i just copied the received over the approved and it seemed to fix. Also had the same problem with stacktrace/path in the apporvals, so I created a custom Ex and overrode stack trace to return a constant string instead of an actual stack |
|
@JakeGinnivan sure :) happy to do this once everything stabilized after merge etc ?? |
|
There is a built in scrubber to fix the path. Checkout how i fixed Sent from my Windows Phone From: Jason Robertsmailto:notifications@github.com Yeah I got that, i just copied the received over the approved and it seemed to fix. Also had the same problem with stacktrace/path in the apporvals, so I created a custom Ex and overrode stack trace to return a constant string instead of an actual stack — |
|
I saw the stack trace scrubber. It's awesome!! |
|
Rebased over top of updated example branch (which now has metro html report), and good to merge |
There was a problem hiding this comment.
This shouldn't be needed. I've changed TC settings to convert the line endings to CRLF.
Previous approval tests worked without this.
P.S. somehow all PRs are broken on TC!!!
There was a problem hiding this comment.
Master is broken. I changed it to checkout on agent, which ignores that checkbox in teamcity but does not ignore .gitattributes
I think the examples branch is fine?
There was a problem hiding this comment.
No, all active branches are broken. I will change it back if you don't mind to see if it makes a difference. With that setting we shouldn't really need to ignore approved files, ay?
There was a problem hiding this comment.
Just changed the setting back to checkout on server and all PRs and master are green again. I think we should take approved out of .gitignore. It's a bit of pain to deal with these as binary.
There was a problem hiding this comment.
K, binary tells git not to normalise line endings on approved. I hate line endings
There was a problem hiding this comment.
I tried hard to make that work on the first approval test Michael wrote and couldn't do it - somehow TC would completely ignore the .gitattributes (and I had set it to checkout on agent). So I went for CRLF setting and it worked.
P.S. by all gitignore bits above I meant gitattribs :)
3 participants
No description provided.