support RNA sequence in gb file #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLN-54033: support RNA sequence
|
Hi @tnrich, I added some code to enhance the existing the RNA parser for gb file. Please help review it, thanks. |
tnrich
reviewed
Jul 24, 2023
There was a problem hiding this comment.
@sunm19810-pki looking good. Can you please add tests for these changes?
Thanks!
|
Hi @tnrich has added some tests to cover the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 support reading the RNA type info from locus line in gb file
2 for RNA, use 'U' as the complement base