Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix excludeMembers lowercase bug #6915

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix excludeMembers lowercase bug #6915

merged 1 commit into from
Oct 3, 2023

Conversation

nf-s
Copy link
Contributor

@nf-s nf-s commented Sep 28, 2023 •
edited
Loading

Fix excludeMembers lowercase bug

I forgot to add toLowerCase before comparing excludeMembers and model name or id

Test me

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@nf-s nf-s mentioned this pull request Sep 28, 2023
Closed
@nf-s nf-s changed the title Fix excludeMembers lowecase bug Fix excludeMembers lowercase bug Sep 28, 2023
@nf-s
Copy link
Contributor Author

nf-s commented Sep 28, 2023

Before vs After

image

@nf-s nf-s mentioned this pull request Oct 3, 2023
Closed
mwu2018
mwu2018 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@mwu2018 mwu2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwu2018 mwu2018 merged commit 85c8bd1 into main Oct 3, 2023
@mwu2018 mwu2018 deleted the lowercase-bug branch October 3, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwu2018 mwu2018 mwu2018 approved these changes

Assignees

@mwu2018 mwu2018

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nf-s @mwu2018