Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve allMappableMembersInWorkbench function. #6914

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Improve allMappableMembersInWorkbench function. #6914

merged 2 commits into from
Sep 28, 2023

Conversation

mwu2018
Copy link
Contributor

@mwu2018 mwu2018 commented Sep 28, 2023 •
edited
Loading

What this PR does

Fixes #6913

Test me

before

after

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

staffordsmith83
staffordsmith83 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@staffordsmith83 staffordsmith83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted edge case, thanks @mwu2018 approved!

@mwu2018 mwu2018 merged commit 57ab732 into main Sep 28, 2023
@mwu2018 mwu2018 deleted the issue-6913 branch September 28, 2023 06:28
@AnaBelgun AnaBelgun mentioned this pull request Sep 28, 2023
Closed
@nf-s nf-s mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staffordsmith83 staffordsmith83 staffordsmith83 approved these changes

Assignees

@staffordsmith83 staffordsmith83

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag CatalogGroup needs to support other group type when displayGroup set to true
2 participants
@mwu2018 @staffordsmith83