Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare #5529

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

Compare #5529

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
cfef002
Add compare workflow.
na9da May 25, 2021
310040b
Merge branch 'next' into compare
na9da May 31, 2021
0ef32ae
Fix import of createGuid.
na9da May 31, 2021
94aad69
Hide map dataset count & bottom dock on mount.
na9da Jun 1, 2021
65abd73
Add left & right date pickers.
na9da Jun 1, 2021
1c20ee5
DateTimePicker customizations required for the compare workflow.
na9da Jun 3, 2021
44a7c2f
Add location date filter.
na9da Jun 3, 2021
b849064
Extract doesImageryBelongToCatalogItem.
na9da Jun 3, 2021
a5e665b
Stop rendering stray "0" in DOM.
na9da Jun 3, 2021
bc31990
Remove unused imports.
na9da Jun 3, 2021
b3b6632
Fix map button styles.
na9da Jun 4, 2021
f8ea537
Cancel mouse pick when interacting with other elements.
na9da Jun 4, 2021
04d2094
Add location picking status updates.
na9da Jun 7, 2021
0b0d1e0
Activate/deactivate timeline stack when mounting/unmounting the timeline
na9da Jun 7, 2021
902d08d
Show legends for left/right items.
na9da Jun 7, 2021
4a43fb9
Change compare icons in workflow panel.
na9da Jun 8, 2021
1665b80
Style the datepicker more closely to the design.
na9da Jun 8, 2021
e50319c
Make workflow panel scrollable.
na9da Jun 8, 2021
d71d766
Use workflowPanelWidth instead of workbenchWidth.
na9da Jun 8, 2021
1c4a3d5
Add the clone item after the parent item.
na9da Jun 8, 2021
e4988f2
Fix bug that shows the drag-n-drop notification when it is not in use.
na9da Jun 8, 2021
b2f7aa7
Remove old splitter controls from the workbench.
na9da Jun 8, 2021
3bf6f83
Show compare mode when splitter is turned on.
na9da Jun 8, 2021
97d52cf
Import style helper.
na9da Jun 8, 2021
cf8f196
Remove stray attribute.
na9da Jun 8, 2021
a0f9a33
Add method docs.
na9da Jun 9, 2021
a9449e5
Merge branch 'next' into compare
na9da Jun 9, 2021
f98bfa2
Merge branch 'upgrade-html-to-react' into compare
na9da Jun 10, 2021
cbf8317
Pass option to ignore splitter when picking features via the
na9da Jun 10, 2021
4f925bc
Merge branch 'next' into compare
na9da Jun 10, 2021
3068580
Add feature flag `useExperimentalCompareWorkflow` to gate the new
na9da Jun 10, 2021
74e80f9
Exit pick mode when mousedown on elements other than the map.
na9da Jun 10, 2021
0beb983
Remove stale component.
na9da Jun 10, 2021
b6ad9a8
Fix test for map element.
na9da Jun 10, 2021
d4d6252
Enable experimental compare workflow via URL hash parameter.
na9da Jun 10, 2021
c8f9ef6
Check for props change when scrolling to selected date.
na9da Jun 16, 2021
8159eff
Replace find with some.
na9da Jun 16, 2021
20358b2
Merge branch 'next' into compare
na9da Jun 18, 2021
0b2c52c
Update CHANGES.md.
na9da Jun 18, 2021
5e46676
Merge branch 'main' into compare
na9da Oct 15, 2021
c8aeb23
Show workbench controls for compare items.
na9da Oct 15, 2021
b5d56c4
Disable items in both panels only when the user directly triggers the…
na9da Oct 18, 2021
3dcb14e
Re-implemented context items.
na9da Nov 3, 2021
3818db1
Merge branch 'main' into compare
na9da Nov 3, 2021
155418c
More compare workflow changes.
na9da Nov 4, 2021
355eeb8
Restore leftSmall and rightSmall icons.
na9da Nov 4, 2021
9149ed4
Fix broken specs.
na9da Nov 4, 2021
17fe50a
Added menu option to send all context items to front or back.
na9da Nov 7, 2021
ba1a06b
Highlight panel menu selection.
na9da Nov 7, 2021
820635f
Fix workflow/side panel animations.
na9da Nov 8, 2021
c95cdbe
Unset left/right panel item IDs if we cannot resolve them to an item.
na9da Nov 8, 2021
3d1e55a
Fix compare and explorer modal interaction.
na9da Nov 9, 2021
5786630
Improve styling.
na9da Nov 9, 2021
56f7f1f
Wrap item list checkbox text.
na9da Nov 10, 2021
91dab24
Add placeholder text for entire map panel.
na9da Nov 10, 2021
8a39561
Fixing a few bugs.
na9da Nov 11, 2021
15e0136
Merge branch 'main' into compare
na9da Nov 11, 2021
652e216
Fix timeline rendering.
na9da Nov 11, 2021
85405aa
Added comment for temp fix to timeline readjustment.
na9da Nov 11, 2021
434b3bd
Merge branch 'fix-super-get' into compare
na9da Nov 12, 2021
13c8261
Merge branch 'main' into compare
na9da Nov 12, 2021
5dbbe31
Fix lint errors.
na9da Nov 12, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove old splitter controls from the workbench.
  • Loading branch information
na9da committed Jun 8, 2021
commit b2f7aa7a84412606da77df6f11712899d6a8d01a
119 changes: 0 additions & 119 deletions lib/ReactViews/Workbench/Controls/LeftRightSection.jsx

This file was deleted.

2 changes: 0 additions & 2 deletions lib/ReactViews/Workbench/WorkbenchItem.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import DateTimeSelectorSection from "./Controls/DateTimeSelectorSection";
import DimensionSelectorSection from "./Controls/DimensionSelectorSection";
import DisplayAsPercentSection from "./Controls/DisplayAsPercentSection";
import FilterSection from "./Controls/FilterSection";
import LeftRightSection from "./Controls/LeftRightSection";
import Legend from "./Controls/Legend";
import OpacitySection from "./Controls/OpacitySection";
import SatelliteImageryTimeFilterSection from "./Controls/SatelliteImageryTimeFilterSection";
Expand Down Expand Up @@ -167,7 +166,6 @@ export const WorkbenchItemRaw = observer(
viewState={this.props.viewState}
/>
<OpacitySection item={workbenchItem} />
<LeftRightSection item={workbenchItem} />
<TimerSection item={workbenchItem} />
<If
condition={
Expand Down
4 changes: 0 additions & 4 deletions lib/ReactViews/Workbench/WorkbenchList.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import React from "react";
import PropTypes from "prop-types";
import Sortable from "react-anything-sortable";

import WorkbenchSplitScreen from "./WorkbenchSplitScreen";
import WorkbenchItem from "./WorkbenchItem";
import { observer } from "mobx-react";
import { action } from "mobx";
Expand All @@ -28,9 +27,6 @@ class WorkbenchList extends React.Component {
render() {
return (
<ul className={Styles.workbenchContent}>
{this.props.terria.showSplitter && (
<WorkbenchSplitScreen terria={this.props.terria} />
)}
<Sortable onSort={this.onSort} direction="vertical" dynamic={true}>
<For each="item" of={this.props.terria.workbench.items}>
<WorkbenchItem
Expand Down