Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to close Story panel (other than by clicking the Story button again) #3557

Open
wants to merge 2 commits into
base: terriajs7
Choose a base branch
from

Conversation

chloeleichen
Copy link
Contributor

@chloeleichen chloeleichen commented Jul 1, 2019

#3537

Suggested solution
Screen Shot 2019-07-01 at 10 33 35 AM

@chloeleichen
Copy link
Contributor Author

DO NOT MERGE, FURTHER DESIGN NEEDED

@kring kring changed the title fix #3537 Add ability to close Story panel (other than by clicking the Story button again) Jul 8, 2019
@AnaBelgun
Copy link
Member

@philipgrimmett ping for refinement of design

@philipgrimmett
Copy link
Contributor

philipgrimmett commented Aug 5, 2019

Screen Shot 2019-08-05 at 10 28 55 am

Invision prototype with 'hide panel' button for data stories editor:
https://invis.io/43RSPX2U5JD#/360676208_story_-_Panel_Open

@zoran995
Copy link
Collaborator

zoran995 commented Dec 7, 2020

Should this be closed, it is implemented in both master and mobx

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants