fix: remove keyType from encrypted fields #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyType is not sensitive data (just 'rsa', 'ed25519', 'auto', etc.) and was being incorrectly encrypted, causing SSH connection failures with the error: 'Cannot parse privateKey: Unsupported OpenSSH private key type: slh-rsa' because the client received an encrypted JSON string instead of the key type. - Remove keyType from ENCRYPTED_FIELDS in ssh_data set - Remove keyType from ENCRYPTED_FIELDS in ssh_credentials set Fixes SSH key authentication for metrics and terminal connections. Tested: Verified metrics collection returns real data (CPU, memory, disk, uptime) after this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
keyTypefrom ENCRYPTED_FIELDS inssh_datasetkeyTypefrom ENCRYPTED_FIELDS inssh_credentialssetProblem
keyTypewas being incorrectly encrypted as if it were sensitive data. However,keyTypeonly contains non-sensitive metadata values like "rsa", "ed25519", or "auto".This caused SSH connection failures with the error:
The SSH client library was receiving an encrypted JSON string instead of the simple key type string it expected.
Test plan
🤖 Generated with Claude Code